10000 Fix logging statement so it has the proper scope. by schmmd · Pull Request #2059 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Fix logging statement so it has the proper scope. #2059

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix logging statement so it has the proper scope. #2059

merged 1 commit into from
Nov 15, 2018

Conversation

schmmd
Copy link
Member
@schmmd schmmd commented Nov 15, 2018 •
edited
Loading

I noticed some root-level log messages for ELMo in the demo logging. After this change they will have the proper __name__.

INFO:__main__:loading coreference-resolution model
INFO:__main__:loading named-entity-recognition model
INFO:root:Initializing ELMo

@schmmd schmmd requested a review from matt-peters November 15, 2018 19:32
@matt-peters
Copy link
Contributor

👍

@schmmd schmmd merged commit 6ecd193 into allenai:master Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matt-peters matt-peters matt-peters approved these changes

Assignees

@matt-peters matt-peters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmmd @matt-peters
0