This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Minor fixes to help evaluate ELMo port. #2172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Display loss when running evaluate.
- Fixes Compute loss for evaluation. #1241
- Log when sentences are dropped due to exceeding the maximum length.
|
A tiny one. Please take a look! |
joelgrus
reviewed
Dec 12, 2018
| loss = output_dict["loss"].item() | ||
| metrics["loss"] = loss | ||
| cumulative_loss += loss | ||
|
|
There was a problem hiding this comment.
is the consistency a real worry? I think you could make this a tiny bit simpler, something like
loss_count = 0
total_loss = 0.0
# ...
loss = model(**batch).get("loss")
# ...
if loss is not None:
metrics["loss"] = loss.item()
total_loss += loss.item()
loss_count += 1
# ...
if loss_count > 0:
final_metrics["loss"] = total_loss / loss_count
I feel like that's cleaner, what do you think?
There was a problem hiding this comment.
Yes, your code definitely reads cleaner. I switched to that, but at the end I raise if loss_count > 0 and batch_count != loss_count. I agree that it's mostly paranoia, but it would be a really nasty silent error.
Hopefully that's sufficiently clean! Let me know.
joelgrus
approved these changes
Dec 12, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.