This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Clean up temporary archive directory at exit #2184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, this looks good! if you don't mind, can you also add a test for this behavior and verify that the test fails before your change and works after your change? I think it's as simple as just adding one line here: https://github.com/allenai/allennlp/blob/master/allennlp/tests/models/archival_test.py#L94 that checks whether a file exists at that temporary training data path |
|
There we go! As you guessed a single line did the trick. I also verified that the test does indeed fail on master. |
joelgrus
approved these changes
Dec 14, 2018
|
for future reference (in case anyone looks back at this PR) I wish there was also a test that checked that the deletion really happens "atexit" but I have no idea how to check that in a unit test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #2180 using the
atexithook proposed by @joelgrus.Please let me know if there are any changes you'd like to see made and I'd be happy to make them.