8000 sanitize environment variables that can't be unicode encoded by joelgrus · Pull Request #2357 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

sanitize environment variables that can't be unicode encoded #2357

Merged
merged 4 commits into from
Jan 15, 2019
Merged

sanitize environment variables that can't be unicode encoded #2357

merged 4 commits into from
Jan 15, 2019

Conversation

joelgrus
Copy link
Contributor

fixes #2348

@joelgrus joelgrus requested a review from schmmd January 14, 2019 18:19
@schmmd
Copy link
Member
schmmd commented Jan 14, 2019

Yikes--jsonnet throws an exception if any environment variable contains non-unicode characters? If so, LGTM.

@joelgrus joelgrus merged commit 6bd5975 into allenai:master Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmmd schmmd schmmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

param_file reader can't deal with unrelated environment variable which contains non utf-8 character
2 participants
@joelgrus @schmmd
0