8000 Ensure vocab is popped off params in recovery mode by alasdairtran · Pull Request #2409 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Ensure vocab is popped off params in recovery mode #2409

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Ensure vocab is popped off params in recovery mode #2409

merged 1 commit into from
Jan 21, 2019

Conversation

alasdairtran
Copy link
Contributor
@alasdairtran alasdairtran commented Jan 21, 2019 •
edited
Loading

PR #2261 is incomplete. If we load an existing vocabulary, the key vocabulary still exists in params. This will cause the line params.assert_empty('base train command') in commands/train.py to raise an assertion later on.

This PR ensures that the key vocab is always popped off params in all cases.

joelgrus
joelgrus approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor
@joelgrus joelgrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@joelgrus joelgrus merged commit 012e42d into allenai:master Jan 21, 2019
@nelson-liu nelson-liu mentioned this pull request Feb 12, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelgrus joelgrus joelgrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alasdairtran @joelgrus
0