8000 Fix typo when loading train state by nelson-liu · Pull Request #2425 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Fix typo when loading train state #2425

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Fix typo when loading train state #2425

merged 3 commits into from
Jan 23, 2019

Conversation

nelson-liu
Copy link
Contributor
@nelson-liu nelson-liu commented Jan 23, 2019 •
edited
Loading

Looks like this causes the --recover flag to crash when loading an old save dir (old = pre trainer refactor).

@nelson-liu nelson-liu requested a review from joelgrus January 23, 2019 06:12
@nelson-liu
Copy link
Contributor Author
nelson-liu commented Jan 23, 2019 •
edited
Loading

ah i see this is a subset of #2352. would be good to get at least this typo fix merged asap, though, since the --recover flag is currently broken without it.

@joelgrus joelgrus merged commit b7d56ae into allenai:master Jan 23, 2019
@nelson-liu nelson-liu deleted the fix_trainer_typo branch January 23, 2019 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelgrus joelgrus joelgrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelson-liu @joelgrus
0