This repository was archived by the owner on Dec 16, 2022. It is now read-only.
make bag_of_word_counts token embedder ignore padding and UNK tokens #2432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you give it a more descriptive name so that when we look back on closed PRs it's obvious what this one does? e.g. "make bag_of_words token embedder ignore padding and UNK tokens" |
added 4 commits
January 23, 2019 19:25
joelgrus
reviewed
Jan 24, 2019
allennlp/modules/token_embedders/bag_of_word_counts_token_embedder.py
Outdated
Show resolved
Hide resolved
allennlp/modules/token_embedders/bag_of_word_counts_token_embedder.py
Outdated
Show resolved
Hide resolved
allennlp/modules/token_embedders/bag_of_word_counts_token_embedder.py
Outdated
Show resolved
Hide resolved
allennlp/modules/token_embedders/bag_of_word_counts_token_embedder.py
Outdated
Show resolved
Hide resolved
|
@joelgrus incorporated all your comments, ready for another look! |
joelgrus
approved these changes
Feb 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ignores padding and (optionally) UNK tokens in the bag of word count embeddings.