This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Make warnings errors and filter library warnings from pytest #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 95d526a
|
@matt-gardner I made a separate PR to which to push my additional changes so I didn't cause any confusion. Merging this will also close @WrRan's PR as this is a superset of his changes. The only commit you need to look at is 70c064f. Unfortunately filtering the warnings is a bit ugly. |
|
On second thought--since we're squash merging I might need to close the other PR manually. |
matt-gardner
approved these changes
Feb 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting some strange errors locally and wanted to push to GitHub to run CI. I created a separate PR so I didn't pollute #2282 with changes that might not need to be kept.