This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Scope DeprecationWarning errors to just allennlp-internal stuff #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmmd
approved these changes
Feb 28, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of people have mentioned test failures when running locally. I just tried it myself and discovered that updates to other libraries added some deprecation warnings that are causing our tests to fail. This was not the intent of the deprecation-warning-into-error stuff that we did - we just wanted to make sure we weren't adding deprecation warnings ourselves without fixing our own code first. So this PR changes the policy to ignore all non-allennlp deprecation warnings, and fail only on allennlp ones (I confirmed that adding a deprecation warning inside of allennlp causes test failures, as intended).