8000 Add official DROP evaluation script by matt-gardner · Pull Request #2559 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Add official DROP evaluation script #2559

Merged
merged 4 commits into from
Mar 1, 2019

Conversation

matt-gardner
Copy link
Contributor

This is me taking and cleaning up the evaluation script that @dDua wrote, from the private DROP repo, along with tests. It has already had two pairs of eyes on it.

@matt-gardner matt-gardner requested a review from pdasigi March 1, 2019 22:17
Copy link
Member
@pdasigi pdasigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we need a test for evaluate_json though.

@matt-gardner
Copy link
Contributor Author

Yes, we do. Maybe @dDua can add one with some of her examples in a subsequent PR?

@matt-gardner matt-gardner merged commit 4d5eade into allenai:master Mar 1, 2019
@matt-gardner matt-gardner deleted the drop_evaluator branch March 1, 2019 22:33
reiyw pushed a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
* Added (initial version of) the DROP evaluation script

* Updated eval script

* Docs

* pylint, mypy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0