This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Fix TextClassificationJsonReader handling of unlabeled instances #2621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nelson-liu, don't worry too much about merging into master all the time. If you know that what you're doing doesn't conflict with other open PRs, it's not a big deal, and we can just override that check when merging. |
|
ok, thanks @matt-gardner ! |
|
@matt-gardner want to override the "out-of-date with the base branch" check? I don't have the privileges. |
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
…enai#2621) * Fix docstring to accurately reflect input expectations * Fix TextClassificationJson reader handling of unlabeled data
TalSchuster
pushed a commit
to TalSchuster/allennlp-MultiLang
that referenced
this pull request
Feb 20, 2020
…enai#2621) * Fix docstring to accurately reflect input expectations * Fix TextClassificationJson reader handling of unlabeled data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ended up running into this myself, so this fixes #2619
This fix is required to use the dataset reader while predicting on unlabeled text.
Also adds a small doc fix.