This repository was archived by the owner on Dec 16, 2022. It is now read-only.
final_state_tuple is a Tuple #2645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-ai2
approved these changes
Mar 25, 2019
| @@ -106,5 +106,5 @@ def forward(self, # pylint: disable=arguments-differ | |||
| output_sequence, final_state = layer(output_sequence, state) | |||
| final_states.append(final_state) | |||
|
|
|||
| final_state_tuple = (torch.cat(state_list, 0) for state_list in zip(*final_states)) | |||
| final_state_tuple = tuple(torch.cat(state_list, 0) for state_list in zip(*final_states)) | |||
There was a problem hiding this comment.
Could you please add a return type on line 74 and correct the Returns section of the docstring?
DeNeutoy
reviewed
Mar 25, 2019
|
|
||
| def test_wrapper_works_with_alternating_lstm(self): | ||
| model = PytorchSeq2VecWrapper( | ||
| StackedAlternatingLstm(input_size=100, |
There was a problem hiding this comment.
No need for the test fixture to be this size, it makes them slow - just use 4,5 etc.
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
Fixes allenai#2503. The `final_state_tuple` in the `StackedAlternatingLstm` was a generator instead of a tuple.
TalSchuster
pushed a commit
to TalSchuster/allennlp-MultiLang
that referenced
this pull request
Feb 20, 2020
Fixes allenai#2503. The `final_state_tuple` in the `StackedAlternatingLstm` was a generator instead of a tuple.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2503. The
final_state_tuplein theStackedAlternatingLstmwas a generator instead of a tuple.