This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Number predictions #2709
Merged
Number predictions #2709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelgrus
reviewed
Apr 15, 2019
| @@ -171,14 +172,17 @@ def _get_instance_data(self) -> Iterator[Instance]: | |||
|
|
|||
| def run(self) -> None: | |||
| has_reader = self._dataset_reader is not None | |||
| index = 0 | |||
There was a problem hiding this comment.
you may find this too cute, but one thing you could do to avoid having to track and increment the indices would be
index = itertools.count()
which generates an infinite sequence 0, 1, 2, ...
and then grab its value like
self._maybe_print_to_console_and_file(next(index), result, ...)
There was a problem hiding this comment.
@joelgrus I loved doing things like that in Scala, but I have avoided them in Python (unpythonic?)
There was a problem hiding this comment.
seems fine to me, as long as it's clear what's happening
|
@schmmd, this will be useful. Can you update and merge this? |
joelgrus
approved these changes
May 7, 2019
|
@HarshTrivedi I'll merge after CI. |
|
@schmmd Thanks! 👍 |
reiyw
pushed a commit
to reiyw/allennlp
that referenced
this pull request
Nov 12, 2019
TalSchuster
pushed a commit
to TalSchuster/allennlp-MultiLang
that referenced
this pull request
Feb 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running some speed tests and it was difficult to tell how much progress my runs were making. I thought that numbering the predictions would be a good way to add some measure of progress.