8000 Update comment on ELMo NER model to match current configuration by lucky-bai · Pull Request #2761 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Update comment on ELMo NER model to match current configuration #2761

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Update comment on ELMo NER model to match current configuration #2761

merged 1 commit into from
Apr 26, 2019

Conversation

lucky-bai
Copy link
Contributor

Fixes mismatch between code and comments, where attempting to run the pretrained NER model gives the following error:

allennlp.common.checks.ConfigurationError: "Extra parameters passed to CrfTagger: {'constraint_type': 'BIOUL'}"

@lucky-bai lucky-bai changed the title Update model comment to match current configuration Update comment on ELMo NER model to match current configuration Apr 26, 2019
Copy link
Contributor
@DeNeutoy DeNeutoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DeNeutoy DeNeutoy merged commit c6ddb9d into allenai:master Apr 26, 2019
reiyw pushed a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
TalSchuster pushed a commit to TalSchuster/allennlp-MultiLang that referenced this pull request Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0