8000 Make _replace_none properly handle "None" in parameter lists by matt-gardner · Pull Request #2774 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Make _replace_none properly handle "None" in parameter lists #2774

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Make _replace_none properly handle "None" in parameter lists #2774

merged 1 commit into from
Apr 29, 2019

Conversation

matt-gardner
Copy link
Contributor

No description provided.

@matt-gardner matt-gardner requested a review from DeNeutoy April 29, 2019 19:02
DeNeutoy
Copy link
Contributor
@DeNeutoy DeNeutoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt-gardner matt-gardner merged commit b97bca0 into allenai:master Apr 29, 2019
@matt-gardner matt-gardner deleted the replace_nones_in_param_list branch April 29, 2019 20:58
reiyw pushed a commit to reiyw/allennlp that referenced this pull request Nov 12, 2019
@matt-gardner @reiyw
Make _replace_none properly handle "None" in parameter lists (allenai…
d31c0df 
…#2774)
TalSchuster pushed a commit to TalSchuster/allennlp-MultiLang that referenced this pull request Feb 20, 2020
@matt-gardner @TalSchuster
Make _replace_none properly handle "None" in parameter lists (allenai…
7ebfefd 
…#2774)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeNeutoy DeNeutoy DeNeutoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-gardner @DeNeutoy
0