8000 Feat/mipidsi async support by xgroleau · Pull Request #72 · almindor/mipidsi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat/mipidsi async support #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Feat/mipidsi async support #72

wants to merge 6 commits into from

Conversation

xgroleau
Copy link
Contributor
@xgroleau xgroleau commented Aug 21, 2023 •
edited
Loading

Reimplemented using async as discussed in #63. Pretty much copy/paste with async/await keywords

Couples things to note and discussion points:

  • Async crate uses the alpha embedded-hal
  • Currently using the git version of display-interface, we might want to wait for the release
  • Some things where made public to allow reuse from the non async to async crate.
    • We could use a -common crate and put everything public and the crate but not reexport it in the main crates
  • Currently the doc is copy/pasted, we might want to modify some things or just reference the base library? (e.g. "Async version of [mipidsi::Display]") Whatever you think is best for the doc

@xgroleau xgroleau mentioned this pull request Sep 13, 2023
Closed
@KortanZ KortanZ mentioned this pull request May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almindor almindor Awaiting requested review from almindor almindor will be requested when the pull request is marked ready for review almindor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xgroleau
0