Resolve "Refactor the process of initializing collector" #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor alpamon to prevent termination when collector initialization fails.
Add CollectorRestartChan to WebsocketClient to receive collector restart commands. Implement RestartCollector() to send a signal to CollectorRestartChan upon receiving collector restart command.
Add logic to restart the collector when a restart request signal is received on wsClient.CollectorRestartChan. To implement this, add for-select block.
Add restartcoll command case to trigger collector restarts.
Modify Transporter to not retry metric transmissions when 400 error occurs.
Merge the 'restartcoll' command into the 'restart' command, considering the future addition of other targets besides the collector.
royroyee
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #56, refactor collector initialization process.
Additionally, Modify Transporter to not retry metric transmissions when 400 error occurs.
Closes #56