8000 cakePHP 4.x compatiblity by mimorocks · Pull Request #55 · alt3/cakephp-swagger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cakePHP 4.x compatiblity #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 27, 2020
Merged

cakePHP 4.x compatiblity #55

merged 11 commits into from
Feb 27, 2020

Conversation

mimorocks
Copy link
Contributor

proposing new branch cake-4.x

fixes #51

@bravo-kernel
Copy link
Contributor

Thanks, looks like the test-suite needs updating as well. If you manage to get this all green I will release a new version. ❤️

@mimorocks
Copy link
Contributor Author

yes. I did not have time yet to look into that. will keep trying to get it green :)

@bravo-kernel
Copy link
Contributor

take all the time you need, I will probably not be able to review/merge until this Friday anyway. Appreciate it 👍

@codecov-io
Copy link
codecov-io commented Feb 26, 2020 •
edited
Loading

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #55   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       32     32           
=======================================
  Files             5      5           
  Lines            99     99           
=======================================
  Hits             99     99
Impacted Files Coverage Δ Complexity Δ
src/Controller/AppController.php 100% <100%> (ø) 2 <2> (ø) ⬇️
src/Lib/SwaggerTools.php 100% <100%> (ø) 11 <0> (ø) ⬇️
src/Controller/UiController.php 100% <100%> (ø) 3 <0> (ø) ⬇️
src/Controller/DocsController.php 100% <100%> (ø) 13 <0> (ø) ⬇️
src/Shell/SwaggerShell.php 100% <100%> (ø) 3 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc7b03...d9e5391. Read the comment docs.

@mimorocks
Copy link
Contributor Author

I am not really used to working with travis and/or phpunit/phpcs
I have still one failing step. phpcs seems to be missing? but I don't know why. @bravo-kernel any ideas?

The command "sh -c "if [ '$PHPCS' = '1' ]; then vendor/bin/phpcs -p --extensions=php --standard=vendor/cakephp/cakephp-codesniffer/CakePHP ./src ./tests ./config --ignore=.webroot; fi"" exited with 2.

@bravo-kernel
Copy link
Contributor

Not an idea but... I can share how I have always done it from day one.

I always take https://github.com/UseMuffin/Slug as an example of how things should be done (as those maintainers know what they are doing) and then compare what they have in their travis.yml and try to mimic that. E.g.

🤞

@bravo-kernel
Copy link
Contributor

@mimo74 ohhhh, please ignore my previous comment, I was too fast, my bad.

Phpcs is functioning perfectly fine as it is.

There are styling errors in the travis log, see for example https://travis-ci.org/alt3/cakephp-swagger/jobs/655381117#L733 which:

  • tells us routes.php has 3 problems
  • directly below that tells us what error on which line

Fix those 3, push the changes and you will see the list of styling errors decrease. Fix until solved.

@bravo-kernel
Copy link
Contributor

Also, it appears the styling errors are unrelated to your change. These are probably new rule sets now triggering the errors because it has been ages since the last release. I don't want to over-ask you here but if you could fix them that would be awesome.

@bravo-kernel
Copy link
Contributor

Sorry for spamming you, two last things:

  • there is phpcbf to auto-fix issues, just make sure to pass the cakephp rules
  • if you are unable I will be able to fix these somewhere this weekend

@mimorocks
Copy link
Contributor Author

Phpcs is functioning perfectly fine as it is.

ohh... i see.. the lines before where the output of phpcs. I got confused by exited with 2 and interpreted that as not found.

@bravo-kernel
Copy link
Contributor

No worries, phpcs is really good stuff.

@mimorocks
Copy link
Contributor Author

we are green!

@bravo-kernel
Copy link
Contributor

This is all you man, congrats. I will eat something first, then merge and release a new 4.0.0 version.

Awesome job 💯

@bravo-kernel bravo-kernel merged commit 3e0ff40 into alt3:master Feb 27, 2020
@bravo-kernel
Copy link
Contributor 8000

Released as https://github.com/alt3/cakephp-swagger/releases/tag/4.0.0
Packagist updated as well https://packagist.org/packages/alt3/cakephp-swagger

Looks gtm, thanks for this one, really appreciated

@bravo-kernel
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add suport for cakephp 4
3 participants
@mimorocks @bravo-kernel @codecov-io
0