This repository was archived by the owner on May 14, 2025. It is now read-only.
Add full compatibility with Folia 1.21+ #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a big change. Thanks for the PR. I will try to build, test, and merge it asap :) |
|
Add compatibility with PreGenChunk, DynView, and SafetyManager. TODO: Revamp the appearance of all logs for a fresh, modern look. |
|
Started making improved logs, looks ok? |
Definitely looks better :D Edit : Test runs fine with default build command. Let me know if you are ready to merge it :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request implements full plugin compatibility with Folia-based servers (versions 1.21+). Major changes include:
ServerType definition:
Uses the existing ServerType class to determine if a server is running under Folia, allowing conditional application of different ways of scheduling tasks.
Correct execution of synchronous and asynchronous operations:
All operations that require access to world data (e.g., reading chunks, getting tile entities) are now executed on a “synchronous” thread via GlobalRegionScheduler, preventing errors like “Cannot read world asynchronously”.
Heavy calculations and sorting now run asynchronously where possible, and sending messages to the player is always on a synchronous thread.
Compatibility with Classic Paper:
In the absence of Folia, the plugin continues to run as standard using Bukkit.getScheduler().runTask() and runTaskAsynchronously().
Testing:
The changes have been tested on servers running Folia 1.21+ and regular Paper, confirming that all tasks run correctly without world access errors.