fix(config): binding of TMUXAI_OPENROUTER_API_KEY variable #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
8000
div>
|
Thanks for looking into this |
|
There is an issue with this fix - while it does force the API key to load properly, all other nested configs are still broken. IMO it makes sense to drop the AutomaticEnv() invocation as well as it will behave inconsistently. |
|
I will merge this, and will update with EnumerateConfigKeys thank you for first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the binding doesn't work correctly for
TMUXAI_OPENROUTER_API_KEY.I haven't investigated too long, could be because there is no default value defined or something else.
Forcing the binding of the key to the env variable using
BindEnv()does fix the issue.While troubleshooting I noticed the
config.Load()was called twice, so I took the opportunity to remove this redundant call which is already triggered incli.Execute().Close #5