8000 add: gun native export for expo by sirpy · Pull Request #966 · amark/gun · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add: gun native export for expo #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sirpy
Copy link
Collaborator
@sirpy sirpy commented Jun 14, 2020

No description provided.

8000 @sirpy sirpy requested review from amark and mmalmi June 14, 2020 05:53
@amark
Copy link
Owner
amark commented Jun 15, 2020

this is a single line change, why is it causing all of SEA tests to fail? It seems like it would work? I'm excited for Expo support 🎉 tho! I thought you said you'd have to do a random-crypto shim? I don't see that in here, did there turn out to be a simpler solution? I'm excited! :D

@sirpy
Copy link
Collaborator Author
sirpy commented Jun 15, 2020

@amark hmmm that's super strange, shouldnt effect unit tests at all
yes we need the crypto shim, but we keep it as an external package the user has to install, just like for react native.
i've created the package @gooddollar/expo-getrandomvalues-sync

@sirpy
Copy link
Collaborator Author
sirpy commented Jun 15, 2020

@amark i dont know why it runs two different travis builds, /push and /pr i've looked at other PRs and it only runs /pr which passes also here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0