Roundels! #1460
Open
Roundels! #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have schoolwork to do
fix: dynamicy
fix: fabricator no more on ground
fix: emission is now constant and not dumb
… that includes the emissive boolean that can be set via the roundel fabricator (currently is simply set to true for testing)
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # src/main/java/dev/amble/ait/AITMod.java
DrTheodor
requested changes
Apr 23, 2025
| Identifier id = context.id(); | ||
| // This is EXCEPTIONALLY stupid. But so is Mojang. So, in conclusion, fuck you. - Loqor | ||
| if (id != null && ( | ||
| id.toString().contains("ait:roundel#") && !id.toString().contains("ait:roundel_fabricator"))) { |
There was a problem hiding this comment.
i mean
if it contains "ait:roundel#" it cant contain "ait:roundel_fabricator".
There was a problem hiding this comment.
i assume the # checks for everything after that so
src/main/java/dev/amble/ait/core/screens/RoundelFabricatorScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/amble/ait/core/screens/RoundelFabricatorScreenHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/dev/amble/ait/core/screens/RoundelFabricatorScreenHandler.java
Outdated
Show resolved
Hide resolved
DrTheodor
requested changes
Apr 23, 2025
| Identifier id = context.id(); | ||
| // This is EXCEPTIONALLY stupid. But so is Mojang. So, in conclusion, fuck you. - Loqor | ||
| if (id != null && ( | ||
| id.toString().contains("ait:roundel#") && !id.toString().contains("ait:roundel_fabricator"))) { |
| extends AbstractRoundelBlock { | ||
| private static final Map<Integer, Block> COLORED_ROUNDELS = Maps.newHashMap(); | ||
|
|
||
| public RoundelBlock(int dyeColor, AbstractBlock.Settings settings) { |
There was a problem hiding this comment.
so what
since when minecraft became the etalon of performant code?
| @@ -141,7 +141,8 @@ public void removeFuel(double fuel) { | |||
| } | |||
|
|
|||
| public double getFuel() { | |||
| return this.<FuelHandler>handler(TardisComponent.Id.FUEL).getCurrentFuel(); | |||
| FuelHandler fuel = this.handler(TardisComponent.Id.FUEL); | |||
| return fuel.getCurrentFuel(); | |||
There was a problem hiding this comment.
use this.<FuelHandler>handler(TardisComponent.Id.FUEL).getCurrentFuel()
|
Theo we cant reply to some of your coments |
Skill issue, clearly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added Roundels, Roundel Fabricator, and a new datapack system for patterns.
Why / Balance
I'll explain later
Technical details
Media
Requirements
Breaking changes
Changelog