8000 fix: "LINK TO ENGINE VIA FLUID LINKS" being wrong name for artron cables by Addi3 · Pull Request #1534 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: "LINK TO ENGINE VIA FLUID LINKS" being wrong name for artron cables #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

fix: "LINK TO ENGINE VIA FLUID LINKS" being wrong name for artron cables #1534

merged 1 commit into from
May 8, 2025

Conversation

Addi3
Copy link
Collaborator
@Addi3 Addi3 commented May 3, 2025

About the PR

changed LINK TO ENGINE VIA FLUID LINKS

Why / Balance

It was wrong

Technical details

changed LINK TO ENGINE VIA FLUID LINKS to changed LINK TO ENGINE VIA ARTRON CABLESin theAITModDataGenerator` class

Media

NA

Requirements

Breaking changes

NON

Changelog

🆑

  • fix: "LINK TO ENGINE VIA FLUID LINKS" being wrong name for artron cables

@Addi3 Addi3 requested a review from a team as a code owner May 3, 2025 12:05
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. A: Datagen Area: Datagen implementation & API. size/XS Denotes a PR that changes 0-9 lines. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 3, 2025
@GSMPBot GSMPBot requested review from Loqor, MaketendoDev and duzos May 3, 2025 12:06
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted. label May 3, 2025
@Mansarde
Copy link
Collaborator
Mansarde commented May 4, 2025 •
edited
Loading

But aren't fluid links basically Artron cables, because they conduct Artron energy to where it is needed?
"fluid link" because of how they function and "Artron cables" because they conduct Artron.
Making them both refer to the same thing.

EDIT:
Having said that though: while the name isn't wrong, it'd probably be better to be consistent, so we should either call them "fluid links" everywhere or "Artron cables" everywhere".

@DrTheodor DrTheodor added T: Visual Change Type: Deals with changes to art, sprites or other visuals in the mod. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels May 8, 2025
@DrTheodor DrTheodor merged commit 6233801 into main May 8, 2025
11 checks passed
@github-actions github-actions bot added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label May 8, 2025
@DrTheodor DrTheodor deleted the fluidlinks-no-more branch May 8, 2025 11:43
@github-actions github-actions bot removed the S: Needs Review Status: Requires additional reviews before being fully accepted. label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrTheodor DrTheodor DrTheodor approved these changes

@Loqor Loqor Awaiting requested review from Loqor

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

@duzos duzos Awaiting requested review from duzos

Assignees
No one assigned
Labels
A: Datagen Area: Datagen implementation & API. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the mod.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Addi3 @Mansarde @DrTheodor
0