8000 re-initialize the executor service on server startup by DrTheodor · Pull Request #1544 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

re-initialize the executor service on server startup #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

re-initialize the executor service on server startup #1544

merged 1 commit into from
May 8, 2025

Conversation

DrTheodor
Copy link
Member

About the PR

This PR makes it so the executor service for the async locator util is re-initialized on server startup.

Why / Balance

Fixes a bug in singleplayer that occurs when a player leaves a world and rejoins again and uses something that utilizes the async locator util (e.g. randomizer or the thingy that searches for structures).

Requirements

Changelog

🆑

  • fix: randomizer and structure locator no longer throw up when you rejoin the world

@DrTheodor DrTheodor self-assigned this May 8, 2025
@DrTheodor DrTheodor requested a review from a team as a code owner May 8, 2025 11:00
@DrTheodor DrTheodor added T: Bugfix Type: Bugs and/or bugfixes. A: Tardis Components Area: Tardis components & manager. A: General Interactions Area: General in-game interactions that don't relate to another area. A: Core Tech Area: Underlying core tech for the mod and the Github repository. labels May 8, 2025
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 8, 2025
@GSMPBot GSMPBot requested review from Loqor, MaketendoDev and duzos May 8, 2025 11:00
@DrTheodor DrTheodor removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label May 8, 2025
@DrTheodor DrTheodor merged commit 90ae884 into main May 8, 2025
10 checks passed
@DrTheodor DrTheodor deleted the fix/async-locator-termination branch May 8, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loqor Loqor Awaiting requested review from Loqor

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

@duzos duzos Awaiting requested review from duzos

Assignees

@DrTheodor DrTheodor

Labels
A: Core Tech Area: Underlying core tech for the mod and the Github repository. A: General Interactions Area: General in-game interactions that don't relate to another area. A: Tardis Components Area: Tardis components & manager. S: Needs Review Status: Requires additional reviews before being fully accepted. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DrTheodor
0