10000 lazy multidim world load by DrTheodor · Pull Request #1545 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

lazy multidim world load #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 8, 2025
Merged

lazy multidim world load #1545

merged 9 commits into from
May 8, 2025

Conversation

DrTheodor
Copy link
Member

About the PR

This PR makes it so multidim lazily loads the worlds.

Why / Balance

Because performance.

Technical details

This PR bumped multidim to 2.1.3. Also, this PR utilizes a mixin to forcefully load the tardis when the player logs on. This was made to make sure that minecraft doesnt spit the player out.

Requirements

Changelog

🆑

  • fix: worlds with a lot of tardises will not load all the tardis worlds on start up anymore

@DrTheodor DrTheodor self-assigned this May 8, 2025
@DrTheodor DrTheodor requested a review from a team as a code owner May 8, 2025 11:20
@DrTheodor DrTheodor added T: Performance Type: Performance impacting changes or bugs. C: Networking Changes: Might require knowledge of networking. A: Tardis Components Area: Tardis components & manager. A: Core Tech Area: Underlying core tech for the mod and the Github repository. C: Chunks Changes: Might require knowledge of worlds, chunks and blocks. labels May 8, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 8, 2025
@GSMPBot GSMPBot requested a review from duzos May 8, 2025 11:20
@github-actions github-actions bot added the A: Console Area: Tardis console. label May 8, 2025
@DrTheodor DrTheodor added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 8, 2025
@DrTheodor DrTheodor merged commit a0b9173 into main May 8, 2025
8 checks passed
@DrTheodor DrTheodor deleted the fix/lazy-multidim-load branch May 8, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duzos duzos Awaiting requested review from duzos

Assignees

@DrTheodor DrTheodor

Labels
A: Console Area: Tardis console. A: Core Tech Area: Underlying core tech for the mod and the Github repository. A: Tardis Components Area: Tardis components & manager. C: Chunks Changes: Might require knowledge of worlds, chunks and blocks. C: Networking Changes: Might require knowledge of networking. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Performance Type: Performance impacting changes or bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DrTheodor
0