8000 revert world border restrictions & add biome caching by DrTheodor · Pull Request #1549 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

revert world border restrictions & add biome caching #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

revert world border restrictions & add biome caching #1549

merged 1 commit into from
May 9, 2025

Conversation

DrTheodor
Copy link
Member

About the PR

This PR reverts world border restrictions of the #1548 and adds biome caching to the tardis world.

Why / Balance

A bunch of people came with pitchforks and torches.

Technical details

Biome caching is done through lazy initialization.

Requirements

Changelog

🆑

  • tweak: slightly improved biome check of the tardis world

@DrTheodor DrTheodor 8000 self-assigned this May 9, 2025
@DrTheodor DrTheodor requested a review from a team as a code owner May 9, 2025 16:01
@DrTheodor DrTheodor added T: Performance Type: Performance impacting changes or bugs. Intent: Hotfix PR Intent: Something that should be applied via hotfix procedure. A: Tardis Components Area: Tardis components & manager. C: Chunks Changes: Might require knowledge of worlds, chunks and blocks. labels May 9, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Needs Review Status: Requires additional reviews before being fully accepted. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels May 9, 2025
@GSMPBot GSMPBot requested review from Loqor, MaketendoDev and duzos May 9, 2025 16:01
duzos
duzos approved these changes May 9, 2025
View reviewed changes
Copy link
Member
@duzos duzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duzos duzos merged commit 9010037 into main May 9, 2025
11 checks passed
@duzos duzos deleted the a-bit-more-perf-fixes branch May 9, 2025 17:43
@github-actions github-actions bot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may requ 8000 ire another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duzos duzos duzos approved these changes

@Loqor Loqor Awaiting requested review from Loqor

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

Assignees

@DrTheodor DrTheodor

Labels
A: Tardis Components Area: Tardis components & manager. C: Chunks Changes: Might require knowledge of worlds, chunks and blocks. Intent: Hotfix PR Intent: Something that should be applied via hotfix procedure. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. T: Performance Type: Performance impacting changes or bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrTheodor @duzos
0