8000 Theo's performance fixes ch1: epilogue by DrTheodor · Pull Request #1559 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Theo's performance fixes ch1: epilogue #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Theo's performance fixes ch1: epilogue #1559

merged 3 commits into from
May 22, 2025

Conversation

DrTheodor
Copy link
Member

About the PR

This PR attempts to improve performance and stability of AIT.

Why / Balance

The server has been crashing lately.

Technical details

This PR uses the new scheduler API to schedule tasks at world tick start, rather than server tick end, which should improve stability for block-related operations.

Requirements

Breaking changes

  • All scheduler and queue usages must be updated to follow the new 1.1.0 API.

Changelog

🆑

  • perf: improved door waterlog check performance
  • perf: improved performance of queues/scheduled tasks for world-related jobs

@DrTheodor DrTheodor added this to the 1.2.0 PATCHES milestone May 22, 2025
@DrTheodor DrTheodor self-assigned this May 22, 2025
@DrTheodor DrTheodor requested a review from a team as a code owner May 22, 2025 16:54
@DrTheodor DrTheodor added the T: Performance Type: Performance impacting changes or bugs. label May 22, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Tardis Components Area: Tardis components & manager. A: Console Area: Tardis console. S: Needs Review Status: Requires additional reviews before being fully accepted. and removed size/M Denotes a PR that changes 100-999 lines. labels May 22, 2025
@GSMPBot GSMPBot requested a review from duzos May 22, 2025 16:54
duzos
duzos approved these changes May 22, 2025
View reviewed changes
Copy link
Member
@duzos duzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 22, 2025
@DrTheodor DrTheodor removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label May 22, 2025
@DrTheodor DrTheodor merged commit c3c49fc into main May 22, 2025
9 checks passed
@DrTheodor DrTheodor deleted the theos-performance-fixes-ch1 branch May 22, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duzos duzos duzos approved these changes

Assignees

@DrTheodor DrTheodor

Labels
A: Console Area: Tardis console. A: Tardis Components Area: Tardis components & manager. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. T: Performance Type: Performance impacting changes or bugs.
Projects
None yet
Milestone
1.2.0 PATCHES
Development

Successfully merging this pull request may close these issues.
2 participants
@DrTheodor @duzos
0