8000 fix: handle world load failure better by DrTheodor · Pull Request #1563 · amblelabs/ait · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: handle world load failure better #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

fix: handle world load failure better #1563

merged 3 commits into from
May 26, 2025

Conversation

DrTheodor
Copy link
Member
@DrTheodor DrTheodor commented May 26, 2025 •
edited
Loading

About the PR

This PR improves the multidim world load failure by creating a new world instead of silently failing.

Also, it removes the multidim persistence.

Why / Balance

If multidim fails to save the (useless) world data, it will fail to load it afterwards, even though AIT can provide the same blueprint data with no troubles whatsoever.

Technical details

Requirements

Changelog

🆑

  • fix: make multidim less error-prone

@DrTheodor DrTheodor requested a review from a team as a code owner May 26, 2025 14:28
@github-actions github-actions bot added A: Tardis Components Area: Tardis components & manager. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 26, 2025
@GSMPBot GSMPBot requested review from Loqor, MaketendoDev and duzos May 26, 2025 14:28
duzos
duzos approved these changes May 26, 2025
View reviewed changes
Copy link
Member
@duzos duzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels May 26, 2025
@DrTheodor DrTheodor added A: Core Tech Area: Underlying core tech for the mod and the Github repository. T: Bugfix Type: Bugs and/or bugfixes. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels May 26, 2025
@DrTheodor DrTheodor merged commit 9202e2f into main May 26, 2025
5 checks passed
@DrTheodor DrTheodor deleted the chore/bump-multidim branch May 26, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duzos duzos duzos approved these changes

@Loqor Loqor Awaiting requested review from Loqor

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the mod and the Github repository. A: Tardis Components Area: Tardis components & manager. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrTheodor @duzos
0