8000 Update evaluate.py by MahdiehEbrahimii · Pull Request #90 · amepproject/amep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update evaluate.py #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 19, 2024
Merged

Update evaluate.py #90

merged 4 commits into from
Dec 19, 2024

Conversation

MahdiehEbrahimii
Copy link
Contributor

I made the changes to the nav: int=10 | None. I also updated the nav in the parameters section.

@kay-ro kay-ro linked an issue Dec 6, 2024 that may be closed by this pull request
FRQ: consistency in evaluate classes - nav #63
Closed
@kay-ro kay-ro added this to the release v1.1.0 milestone Dec 6, 2024
kay-ro
kay-ro requested changes Dec 18, 2024
View reviewed changes
Copy link
Member
@kay-ro kay-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the small comments.

  • remove "if None, i.e., all available time steps are used."

kay-ro
kay-ro approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member
@kay-ro kay-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thank you :)

@kay-ro kay-ro merged commit edc996d into develop Dec 19, 2024
3 checks passed
@kay-ro kay-ro deleted the #63 branch December 19, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay-ro kay-ro kay-ro approved these changes

@hechtprojects hechtprojects Awaiting requested review from hechtprojects

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release v1.1.0
Development

Successfully merging this pull request may close these issues.

FRQ: consistency in evaluate classes - nav
2 participants
@MahdiehEbrahimii @kay-ro
0