8000 Temperatures by hechtprojects · Pull Request #96 · amepproject/amep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Temperatures #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Temperatures #96

merged 5 commits into from
Feb 24, 2025

Conversation

hechtprojects
Copy link
Member
@hechtprojects hechtprojects commented Dec 11, 2024

Tkin, Tkin4, Tconf, and Tosc implemented. Please test the corresponding evaluate classes in detail:

  • amep.evaluate.Tkin
  • amep.evaluate.Tkin4
  • amep.evaluate.Tosc
  • amep.evaluate.Tconf

If they run without any errors, please merge into develop. The new features can then be included in the next minor release.

@hechtprojects hechtprojects added this to the release v1.1.0 milestone Dec 11, 2024
@hechtprojects hechtprojects linked an issue Dec 11, 2024 that may be closed by this pull request
Copy link
Member
@kay-ro kay-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when running the

path="examples/data/lammps.h5amep"
traj= amep.load.traj(path)
tkin = amep.evaluate.Tkin(traj, nav=traj.nframes)
tkin4 = amep.evaluate.Tkin4(traj, nav=traj.nframes)
tosc = amep.evaluate.Tosc(traj, .1, nav=traj.nframes)
tconf = amep.evaluate.Tconf(traj,amep.utils.dr_wca, amep.utils.dr2_wca, nav=traj.nframes)

the shape of tkin4.frames is not just (nframes) but (nframes, nparticles) with all the same values.

@hechtprojects hechtprojects self-assigned this Feb 22, 2025
@hechtprojects
Copy link
Member Author

The bugs and descriptions are fixed now.

trying to fix deprecated actions/upload-artifact@v3
kay-ro
kay-ro a BBF5 pproved these changes Feb 24, 2025
Copy link
Member
@kay-ro kay-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kay-ro kay-ro merged commit 78cbff0 into develop Feb 24, 2025
3 checks passed
@kay-ro kay-ro deleted the temperatures branch February 25, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRQ: Temperature calculation
2 participants
0