Adopt AMF modularization changes #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pope1838
reviewed
Mar 29, 2021
| @@ -174,13 +178,17 @@ class ServerDiagnosticTest extends LanguageServerBaseTest { | |||
| } | |||
|
|
|||
| test("DiagnosticManager with invalid clone") { | |||
| class MockDialectDo 8000 mainElementModel extends DialectDomainElementModel { | |||
| class MockDialectDomainElementModel extends BaseUnitModel { | |||
There was a problem hiding this comment.
Estas cambiando un dialect domain element por un base unit. El dialect domain element es un nodo de la instancia mientras que el BU es todo el doc. Porque el cambio?
There was a problem hiding this comment.
MockDialectInstance necesita que su meta sea de tipo BaseUnitModel por el cambio: #286838d en amf-core
There was a problem hiding this comment.
Estoy cambiando el modelo de un dialecto mockeado, antes era un modelo de un DialectDomainElement y ahora se requiere que sea especifico del Base unit el modelo
pope1838
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.