8000 Remove depending on package types for version constraint enforcement by wagoodman · Pull Request #67 · anchore/grype-db · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove depending on package types for version constraint enforcement #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

wagoodman
Copy link
Contributor

We don't want to require grype-db to have knowledge about the full set of package types for version constraint enforcement. This would mean that all vunnel additions would require a grype-db update, which is not ideal.

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the bug Something isn't working label Mar 9, 2023
@wagoodman wagoodman requested review from westonsteimel and a team March 9, 2023 14:31
@westonsteimel
Copy link
Contributor

Those failures on the v5 acceptance tests are due to my recent apk-related enhancements in syft/grype. It's finding new valid vulns that it didn't previously find

@wagoodman
Copy link
Contributor Author
wagoodman commented Mar 9, 2023

That was my thought as well, the results looked alright. I'm opening another PR to update the test fixtures 👍

[update: #68 #69 ]

@wagoodman wagoodman mentioned this pull request Mar 9, 2023
@wagoodman wagoodman enabled auto-merge (squash) March 9, 2023 18:56
@wagoodman wagoodman merged commit 7376505 into main Mar 9, 2023
@wagoodman wagoodman deleted the fix-pkg-deps branch March 9, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0