8000 Add pretty format option by tomersein · Pull Request #2406 · anchore/grype · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add pretty format option #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 1, 2025
Merged

Add pretty format option #2406

merged 7 commits into from
Feb 1, 2025

Conversation

tomersein
Copy link
Contributor
@tomersein tomersein commented Jan 27, 2025 •
edited
Loading

according to this discussion - https://anchorecommunity.discourse.group/t/grype-scans-in-batches-large-sboms/293/11
we have found out that the pretty mode makes the final json very large, we want to reduce the size by default to avoid OOM.

@tomersein
add pretty format
7b647f1 
Signed-off-by: tomersein <tomersein@gmail.com>
@tomersein
add pretty format
babee80 
Signed-off-by: tomersein <tomersein@gmail.com>
@tomersein
add pretty format
8bb5d49 
Signed-off-by: tomersein <tomersein@gmail.com>
@tomersein
add pretty format
1c88908 
Signed-off-by: tomersein <tomersein@gmail.com>
@tomersein
add pretty format
57d2d05 
Signed-off-by: tomersein <tomersein@gmail.com>
@tomersein
Copy link
Contributor Author

fixed @kzantow
i see Validations / CLI tests (Linux) (pull_request) fails, don't have any further information why

@kzantow
Copy link
Contributor
kzantow commented Feb 1, 2025

The logs aren't always the easiest to read. This is the failed test:

--- FAIL: TestCmd (16.22s)
    --- PASS: TestCmd/no-args-shows-help (0.02s)
    --- PASS: TestCmd/empty-string-arg-shows-help (0.02s)
    --- FAIL: TestCmd/ensure_valid_descriptor (10.42s)

@kzantow
chore: update test
cc4c031 
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow
chore: add config description
a851858 
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
kzantow approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor
@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tomersein! (I fixed the test and added config descriptive text)

@kzantow kzantow merged commit 2720733 into anchore:main Feb 1, 2025
10 checks passed
@wagoodman wagoodman changed the title add pretty format Add pretty format option Mar 4, 2025
@wagoodman wagoodman added the enhancement New feature or request label Mar 5, 2025
7228
@BrewTestBot BrewTestBot mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomersein @kzantow @wagoodman
0