fix: use namespace with name when purl is ecosystem golang in purl decoder #2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4becce0 to
31b3c74
Compare
|
@goatwu1993 thank you for the pull request! 🙏 Please could you sign-off the changes. There's some documentation here about the process. |
…cve because namespace not handled Signed-off-by: goatwu1993 <goatwu1993@gmail.com>
31b3c74 to
4e0dfff
Compare
wagoodman
reviewed
Apr 10, 2025
grype/pkg/purl_provider.go
Outdated
| // copy to avoid mutating the original purl object | ||
| name := purl.Name | ||
| if purl.Namespace != "" { | ||
| name = fmt.Sprintf("%s/%s", purl.Namespace, purl.Name) |
There was a problem hiding this comment.
I think this is an ecosystem specific decision -- that is, in some cases the namespace should be added (e.g. golang, maven, etc) where as in others it should not (e.g. rpm, deb, etc).
|
I'll pull changes from #2636 into this so we can get this across the finish line. |
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
|
@wagoodman since I contributed the other PR and the extra commit on this one can I get your review on this? Feels a little awkward piggy backing on a PR to review code I contributed to 😄 |
wagoodman
reviewed
May 2, 2025
Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
wagoodman
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure what i am doing. but this seems to fix #2580