fix: only fallback to language if language is non-blank #2621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
8000
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
wagoodman
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2618
Keeps #2608 fixed
Basically, update the logic so that we search by the Syft package type if it's non-blank and known, then by language if it's non-blank, then by "UnknownPkg" if the language is blank. #2608 was because we weren't searching by a non-blank language when the package type was "UnknownPkg" and #2618 was because we were searching by a blank language instead of "UnknownPkg".
I'll add some unit tests after I check with the team that this approach makes sense.