Close before remove fixes #2233 #2657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Pope <alan.pope@anchore.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
ec9af87 to
92b9ed2
Compare
kzantow
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows appears to require temporary files to be closed before they are removed.
With these changes, the Windows-specific issue described in Grype issue #2233 should be resolved.
I tested doing this on a GitHub Windows runner.
Before
https://github.com/popey/grype/actions/runs/14994111094/job/42124162010
After
https://github.com/popey/grype/actions/runs/14997189770/job/42134575718