8000 Revert Make Native Image contains no embedded SBOM Error Discoverable (#3805) by kzantow · Pull Request #3944 · anchore/syft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert Make Native Image contains no embedded SBOM Error Discoverable (#3805) #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Revert Make Native Image contains no embedded SBOM Error Discoverable (#3805) #3944

merged 1 commit into from
May 30, 2025

Conversation

kzantow
Copy link
Contributor
@kzantow kzantow commented May 30, 2025 •
edited
Loading

This reverts commit 8cbdd38.

Description

This PR reverts the change in #3805 -- the reason for this is there is nothing identifying executables as graalvm executables, so every ELF binary or other executable file may end up adding incorrect unknown information, the only executables that should return unknown information from this cataloger are actual GraalVM executables, so we need to find a way to identify them before restoring the unknown behavior.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added unit tests that cover changed behavior
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

@kzantow
fix: revert incorrect graalvm unknown behavior
1cff6bf 
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow force-pushed the fix/revert-native-image-unknowns branch from 4c095dd to 1cff6bf Compare May 30, 2025 00:02
@kzantow kzantow requested a review from a team May 30, 2025 00:02
@kzantow kzantow mentioned this pull request May 30, 2025
Open
@kzantow kzantow enabled auto-merge (squash) May 30, 2025 01:20
@kzantow kzantow merged commit 576e729 into anchore:main May 30, 2025
12 checks passed
@kzantow kzantow deleted the fix/revert-native-image-unknowns branch May 30, 2025 15:42
@BrewTestBot BrewTestBot mentioned this pull request Jun 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In versions 1.25.0 and later, graalvm-native-image-cataloger adds 3-6 hours to Syft
2 participants
@kzantow @wagoodman
0