8000 Add tool label and match filtering by wagoodman · Pull Request #41 · anchore/yardstick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add tool label and match filtering #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2023
Merged

Add tool label and match filtering #41

merged 5 commits into from
Feb 27, 2023

Conversation

wagoodman
Copy link
Contributor
@wagoodman wagoodman commented Feb 17, 2023 •
edited
Loading

This PR:

  • Adds the ability to specify a tool label, which is useful when you are testing two tools of the same name and version but a different configuration.
  • Adds the ability to filter matches by a callback function for the compare functions
  • Fixes year filter for non-CVEs. While testing it was discovered that some tests were not wired up (thus have not been running in CI), which when corrected showed failing tests. This PR additionally fixes these tests and renames the excluded test files to they are included under CI runs.
  • Adds new derive_year_from_cve_only configuration option such that non-CVE values are ignored when filtering results/labels by year. (default is to use the primary vulnerability ID followed by the CVE if the results are indeterminate).
  • Adds several tests around label and result year filtering to ensure that the behavior is the same for both objects.

@wagoodman
with tool label
4bf70c7 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
add tests for label changes
9cb098a 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
fix scan result tests
a03d569 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
fix cli tests
a1d1726 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman
wagoodman commented Feb 17, 2023
View reviewed changes
@wagoodman wagoodman marked this pull request as ready for review February 17, 2023 20:47
@wagoodman wagoodman changed the title Add tool label Add tool label and match filtering Feb 17, 2023
@wagoodman wagoodman added the enhancement New feature or request label Feb 17, 2023
@wagoodman wagoodman marked this pull request as draft February 17, 2023 21:04
9286
@wagoodman
ensure that year filtering works the same for labels and results
55aba36 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman marked this pull request as ready for review February 27, 2023 17:04
@wagoodman wagoodman merged commit c48dc2e into main Feb 27, 2023
@wagoodman wagoodman deleted the with-tool-label branch February 27, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonsteimel westonsteimel Awaiting requested review from westonsteimel

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @westonsteimel
0