8000 fix: pass full image identifier to tool.capture by westonsteimel · Pull Request #6 · anchore/yardstick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: pass full image identifier to tool.capture #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2022
Merged

fix: pass full image identifier to tool.capture #6

merged 1 commit into from
Nov 25, 2022

Conversation

westonsteimel
Copy link
Contributor
@westonsteimel westonsteimel commented Nov 24, 2022 •
edited
Loading

Pass the full image identifier to the capture function for a tool. The current implementation does not pass in the tag portion of the identifier; however, there will be some tool implementations that require tag to be present. Both syft and grype support passing the full image identifier, so this shouldn't break any existing tools and will enable support for future tools like anchorectl

Signed-off-by: Weston Steimel weston.steimel@anchore.com

@westonsteimel
fix: pass full image identifier to tool.capture
592b005 
Pass the 
8000
full image identifier to the `capture` function for a tool.  The current implementation does not pass in the tag portion of the identifier; however, there will be some tool implementations that require tag to be present.

Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
spiffcs
spiffcs approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor
@spiffcs spiffcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the enhancement.

@westonsteimel westonsteimel merged commit c2d4e65 into main Nov 25, 2022
@westonsteimel westonsteimel deleted the tool-capture-full-image branch November 25, 2022 06:23
@wagoodman wagoodman added the bug Something isn't working label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffcs spiffcs spiffcs approved these changes

@bradleyjones bradleyjones Awaiting requested review from bradleyjones

@robcresswell robcresswell Awaiting requested review from robcresswell

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westonsteimel @spiffcs @wagoodman
0