refactor: pass both image and tool_input as parameters to capture #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow tools to decide how to handle capturing results based on just an image vs some other input such as an SBOM file. For grype and syft it didn't matter because both types of input were handled the same way; however, for other tools (like anchorectl), the commands will be different and both the image name and path to the sbom will be needed. Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
5e90a01 to
2f79439
Compare
wagoodman
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tools to decide how to handle capturing results based on just an image vs some other input such as an SBOM file.
For grype and syft it didn't matter because both types of input were handled the same way; however, for other tools (like anchorectl), the commands will be different and both the image name and path to the sbom will be needed.
Signed-off-by: Weston Steimel weston.steimel@anchore.com