8000 Add support for setting Cache-Control headers by lukechilds · Pull Request #37 · anacronw/multer-s3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for setting Cache-Control headers #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2016
Merged

Add support for setting Cache-Control headers #37

merged 2 commits into from
May 12, 2016

Conversation

lukechilds
Copy link
Contributor

Fixes #36

@LinusU
Copy link
Collaborator
LinusU commented May 12, 2016 •
edited
Loading

LGTM

Can you add documentation as well?

@lukechilds
Copy link
Contributor Author

Yeah, sure 👍

@lukechilds
Copy link
Contributor Author

@LinusU done :)

@LinusU
Copy link
Collaborator
LinusU commented May 12, 2016

Awesome, thanks for your contribution

LGTM

@anacronw
Copy link
Owner

looks good, but I'm honestly not very happy w/ the entire chain of callbacks we're tacking onto it - that's outside of this PR

@LinusU
Copy link
Collaborator
LinusU commented May 12, 2016

@Badunk I'll submit a pull request to fix that as soon as this is merged, sounds good?

@anacronw
Copy link
Owner

oh yeah for sure, thanks @LinusU

@anacronw anacronw merged commit 2bf40ff into anacronw:master May 12, 2016
anacronw pushed a commit that referenced this pull request May 12, 2016
Bumping for #37
accc41f
@lukechilds
Copy link
Contributor Author

Yeah I agree, I threw up in my mouth a little when I saw that, I was just following the convention 😆

It could still be trimmed down quite a bit after your latest PR.

Also, just a suggestion, but instead of manually implementing all the stuff you wanna pass through to S3 (metadata, cache control, acl, content type etc) it might be worth having one s3Params property that gets merged with the default S3 param object. That way people can add any options that the S3 lib supports without requiring any extra modifications to this lib.

@lukechilds lukechilds deleted the cache-control branch May 12, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukechilds @LinusU @anacronw
0