8000 Add support for storageClass option by franciscotfmc · Pull Request #59 · anacronw/multer-s3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for storageClass option #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2016
Merged

Add support for storageClass option #59

merged 2 commits into from
Nov 22, 2016

Conversation

franciscotfmc
Copy link
Contributor

Added the possibility for specifying the storageClass option:

var upload = multer({
  storage: multerS3({
    s3: s3,
    bucket: 'some-bucket',
    acl: 'public-read',
    storageClass: 'STANDARD_IA',
    key: function (req, file, cb) {
      cb(null, Date.now().toString())
    }
  })
})

I just saw that @gregkeys made a pull request that also includes this modification, but there were some conflict issues. Therefore I also copied his README.md updates about the storageClass and added the docs for my last commit about the contentDisposition header.

Hope it helps.

@franciscotfmc
Copy link
Contributor Author

@LinusU @Badunk Any changes of merging this?

@LinusU
Copy link
Collaborator
LinusU commented Nov 21, 2016

LGTM 👍

@anacronw anacronw merged commit e9d8f3a into anacronw:master Nov 22, 2016
anacronw pushed a commit that referenced this pull request Nov 22, 2016
Bump for #59
40508a3
@anacronw
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscotfmc @LinusU @anacronw
0