build: allow building gen_xml standalone #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMakeLists.txt in the tools subdir is written as an independent project list file. However, it failed to build as-is because the dependency to libxml2 was actually inherited by the root list file. Simply find the libxml2 dep explicitely in this list file to fix it. Signed-off-by: Julien Malik <julien.malik@unseenlabs.fr>
The following warning was issued with gcc 11.4:
/iio-emu/tools/genxml.c: In function ‘get_attr_xml2’:
/iio-emu/tools/genxml.c:149:16: warning: ‘strnlen’ specified bound 255 exceeds source size 100 [-Wstringop-overread]
149 | len += strnlen(value, NAME_MAX);
| ^~~~~~~~~~~~~~~~~~~~~~~~
/iio-emu/tools/genxml.c:149:16: warning: ‘strnlen’ specified bound 255 exceeds source size 100 [-Wstringop-overread]
/iio-emu/tools/genxml.c:149:16: warning: ‘strnlen’ specified bound 255 exceeds source size 100 [-Wstringop-overread]
In function ‘get_attr_xml’,
inlined from ‘iio_channel_get_xml’ at /iio-emu/tools/genxml.c:285:15:
/iio-emu/tools/genxml.c:208:16: warning: ‘strnlen’ specified bound 255 exceeds source size 100 [-Wstringop-overread]
208 | len += strnlen(value, NAME_MAX);
| ^~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Julien Malik <julien.malik@unseenlabs.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMakeLists.txt in the tools subdir is written as an independent project list file.
However, it failed to build as-is because the dependency to libxml2 was actually inherited by the root list file.
Simply find the libxml2 dep explicitely in this list file to fix it.