8000 Clarify licenses by pcercuei · Pull Request #924 · analogdevicesinc/libiio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clarify licenses #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Clarify licenses #924

merged 1 commit into from
Jan 13, 2023

Conversation

pcercuei
Copy link
Contributor
@pcercuei pcercuei commented Jan 9, 2023

Libiio was always meant to be LGPL, but the tools, examples and IIOD were supposed to be GPL (as it does not really make sense for them to use LGPL).

However, the SPDX identifiers (and the comment blocks before that) of the source files all stated that the license was LGPL, since the beginning.

Since re-licensing would be quite a headache, because of the huge number of copyright holders, simply embrace the mistake and use the LGPL license for everything.

Signed-off-by: Paul Cercueil paul@crapouillou.net

Libiio was always meant to be LGPL, but the tools, examples and IIOD
were supposed to be GPL (as it does not really make sense for them to
use LGPL).

However, the SPDX identifiers (and the comment blocks before that) of
the source files all stated that the license was LGPL, since the
beginning.

Since re-licensing would be quite a headache, because of the huge number
of copyright holders, simply embrace the mistake and use the LGPL
license for everything.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
@pcercuei pcercuei requested review from mhennerich and nunojsa January 9, 2023 10:07
@pcercuei pcercuei linked an issue Jan 9, 2023 that may be closed by this pull request
@pcercuei
Copy link
Contributor Author
pcercuei commented Jan 9, 2023

@rgetz is that OK for you?

@pcercuei pcercuei merged commit 4d2e075 into master Jan 13, 2023
@pcercuei pcercuei deleted the pcercuei/clarify-licenses branch January 13, 2023 09:34
@rgetz
Copy link
Contributor
rgetz commented Jan 23, 2023

No. It's not Ok.

The examples were GPL; and you moved them to LPGL when you moved to the short license.
3a85aa9

The examples/test cases had been GPL for the last 4 years...
#350

and was done to handle upstream comments.
https://bugzilla.redhat.com/show_bug.cgi?id=1426465

@pcercuei
Copy link
Contributor Author

@rgetz you are totally right. I will fix it ASAP, sorry about that.

@nunojsa you created examples/adrv9002-iiostream.c with a LGPLv2+ license, I will re-license it to GPLv2+, if you are okay with it.

@pcercuei
Copy link
Contributor Author

@rgetz Actually some files in tests/ were already LGPL, see e65a978.

The tests/gen_code.{c,h} were only touched by you and me, so we could re-license the code to GPL, but iio_stresstest.c was also touched by @matejk. We would need his agreement to re-license the code as GPL.

@rgetz
Copy link
Contributor
rgetz commented Jan 23, 2023

Ok - take this as my approval to relicense tests/gen_code.{c,h} and iio_stresstest.c as GPL 2 or greater.

@matejk - can you provide the same for your change to iio_stresstest.c here? Your change is here:
c954463

(which isn't really any "code", it's just the inclusion of a header file, but just to be certain, it would be great to get your approval).

Thanks
-Robin

@rgetz
Copy link
Contributor
rgetz commented Jan 23, 2023

and (of course) @larsclausen wrote the initial iio_stresstest.c on a branch that I based things off of.
dc33705#diff-783ee4febd1be99f4675c2c802e05e5fcbb64d901a83eabbccc05f3a24d5d184

He would need to approve the GPL re-license as well, but it might be covered by his approval in #350 (which was "c files in the ./test directory:" and didn't specify a branch) - but it's better to be as explicit as possible.

@matejk
Copy link
Contributor
matejk commented Jan 24, 2023

@rgetz, I agree with the change if the license.

@larsclausen
Copy link
Contributor

I'm ok with the license change

@nunojsa
Copy link
Contributor
nunojsa commented Jan 30, 2023

@nunojsa you created examples/adrv9002-iiostream.c with a LGPLv2+ license, I will re-license it to GPLv2+, if you are okay with it.

I'm fine with the change...

pcercuei added a commit that referenced this pull request Jan 30, 2023
Revert the previous 2 commits...

The license of the examples and test programs are indeed GPLv2+ and not
LGPLv2.1+, and the SPDX identifiers were wrong.

In the time frame where the examples and test programs were using the
incorrect SPDX identifiers, the only contributor apart from myself was
Nuno Sa, who contributed the adrv9002-iiostream.c example under the
LGPLv2+ license. He gave his consent for the relicense in the following
github thread:
#924

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei added a commit that referenced this pull request Jan 30, 2023
A few files were still licensed under the LGPLv2+.

These files were authored and modified by myself, Robin Getz, Lars-Peter
Clausen and Matej Kenda; all parties gave their consent for the
relicense in the following github thread:
#924

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei added a commit that referenced this pull request Feb 3, 2023
Revert the previous 2 commits...

The license of the examples and test programs are indeed GPLv2+ and not
LGPLv2.1+, and the SPDX identifiers were wrong.

In the time frame where the examples and test programs were using the
incorrect SPDX identifiers, the only contributor apart from myself was
Nuno Sa, who contributed the adrv9002-iiostream.c example under the
LGPLv2+ license. He gave his consent for the relicense in the following
github thread:
#924

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
pcercuei added a commit that referenced this pull request Feb 3, 2023
A few files were still licensed under the LGPLv2+.

These files were authored and modified by myself, Robin Getz, Lars-Peter
Clausen and Matej Kenda; all parties gave their consent for the
relicense in the following github thread:
#924

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License clarification
5 participants
0