8000 sc589-mini: dts: increase partition size to match actual SPI size for latest revisions by artursartamonovsadi · Pull Request #2834 · analogdevicesinc/linux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sc589-mini: dts: increase partition size to match actual SPI size for latest revisions #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: adsp-main-6.12
Choose a base branch
from
Open

sc589-mini: dts: increase partition size to match actual SPI size for latest revisions #2834

wants to merge 1 commit into from

Conversation

artursartamonovsadi
Copy link
@artursartamonovsadi artursartamonovsadi commented Jul 2, 2025 •
edited
Loading

PR Description

sc589-mini: dts: increase partition size to match actual SPI size for latest revisions 1.5 and 2.1

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

nunojsa
nunojsa reviewed Jul 3, 2025
View reviewed changes
Copy link
Collaborator
@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion from my side:

I would start following upstream best practices even in our forks (we try do that in our own fork). It makes it easier then when dealing with upstream. For this patch:

  1. Git subject not fine;
  2. Missing S-o-b tag.

@UtsavAgarwalADI
Copy link
UtsavAgarwalADI commented Jul 3, 2025 •
edited
Loading

spiboot works fine with a minimal image now for yocto 5

root@adsp-sc589-mini:~# df -h
Filesystem                Size      Used Available Use% Mounted on
/dev/mtdblock4           55.1M     29.3M     25.8M  53% /
devtmpfs                  4.0M         0      4.0M   0% /dev
tmpfs                   104.9M         0    104.9M   0% /dev/shm
tmpfs                    42.0M      8.4M     33.5M  20% /run
tmpfs                   104.9M         0    104.9M   0% /tmp
tmpfs                   104.9M      8.0K    104.9M   0% /var/volatile

UtsavAgarwalADI
UtsavAgarwalADI requested changes Jul 3, 2025
View reviewed changes
Copy link
@UtsavAgarwalADI UtsavAgarwalADI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the commit formatting, the changes seem to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunojsa nunojsa nunojsa left review comments

@UtsavAgarwalADI UtsavAgarwalADI UtsavAgarwalADI requested changes

@vasbimpikasadi vasbimpikasadi Awaiting requested review from vasbimpikasadi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artursartamonovsadi @UtsavAgarwalADI @nunojsa
0