8000 Porting the SPIXF_ICC example to MAX32665 by Jacob-Scheiffler · Pull Request #276 · analogdevicesinc/msdk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Porting the SPIXF_ICC example to MAX32665 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 9, 2023
Merged

Porting the SPIXF_ICC example to MAX32665 #276

merged 11 commits into from
Jan 9, 2023

Conversation

Jacob-Scheiffler
Copy link
Contributor

This PR adds the SPIXF_ICC example, originally written for the MAX32650, to the MAX32665. To make it work, I needed to add the same ICC support that was added for the MAX32650 which allows for a single cache controller instance to be operated on at a time. That allowed the SFCC to be enabled and disabled without affecting the state of either ICC0 or ICC1.

@Jacob-Scheiffler
Copy link
Contributor Author

/clang-format-run

@Jacob-Scheiffler
Copy link
Contributor Author

/clang-format-run

Copy link
Contributor
@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few minor things below

< 8000 details-collapsible>
@Jacob-Scheiffler
Copy link
Contributor Author

/clang-format-run

Copy link
Contributor
@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. Caught one last thing in project.mk. Fix that and it's ready for merge.

8000

# For instructions on how to use this system, see
# https://github.com/Analog-Devices-MSDK/VSCode-Maxim/tree/develop#build-configuration

#BOARD=FTHR_RevA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this - Should be BOARD=FTHR or BOARD=FTHR2 for MAX32665.

You can just delete this whole comment header and replace it with the latest one:

https://github.com/Analog-Devices-MSDK/VSCode-Maxim/blob/65af7c61800c7039956f3c1971ffd7915008668d/MaximSDK/Inject/project.mk

I removed the BOARD example because it was causing too much confusion.

@Jacob-Scheiffler Jacob-Scheiffler merged commit 6851544 into analogdevicesinc:main Jan 9, 2023
@Jacob-Scheiffler Jacob-Scheiffler deleted the spixf_icc_port branch January 9, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0