Building archives with text file arguments. #524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will address the same issue we had with linking the .elf files. The command line list of argmuents is too long on Windows machines. This will echo those arguments to a text file and use that file as the input the the archiver.
tim-magnusen
approved these changes
Mar 29, 2023
Jake-Carter
approved these changes
Mar 29, 2023
Good idea. It looks like we can use GitHub hosted windows machines, they're just billed at a higher rate than the Ubuntu machines. Our current consumption isn't close to the monthly limit, so adding a Windows build test shouldn't matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address the same issue we had with linking the .elf files. The command line list of argmuents is too long on Windows machines. This will echo those arguments to a text file and use that file as the input the the archiver.