fix(PeriphDrivers): Fix Stuck Timer When PWM is set to 0 #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7a8d71 to
87e1bad
Compare
Jake-Carter
reviewed
Dec 9, 2023
| * But there should be a tolerance too, to it be catched | ||
| * So that +8 added as toleransa value. | ||
| */ | ||
| while (tmr->cnt >= (pwm + 8)) {} |
There was a problem hiding this comment.
@ozersa What about monitoring the interrupt flag set by the hardware?
We only need to do this check if the timer is currently running. Something like:
int MXC_TMR_RevB_SetPWM(mxc_tmr_revb_regs_t *tmr, uint32_t pwm)
{
int tmr_id = MXC_TMR_GET_IDX((mxc_tmr_regs_t *)tmr);
(void)tmr_id;
MXC_ASSERT(tmr_id >= 0);
if (pwm > (tmr->cmp)) {
return E_BAD_PARAM;
}
bool timera_is_running = tmr->ctrl0 & MXC_F_TMR_CTRL0_EN_A;
bool timerb_is_running = tmr->ctrl0 & MXC_F_TMR_CTRL0_EN_B;
if (timera_is_running || timerb_is_running) {
MXC_TMR_RevB_ClearFlags(tmr); // Clear flags so we can catch the next one
while (!MXC_TMR_RevB_GetFlags(tmr)) {} // Wait for next PWM transition
MXC_TMR_RevB_Stop(tmr); // Pause timer
MXC_TMR_RevB_SetCount(tmr, 0); // Reset the count
MXC_TMR_RevB_ClearFlags(tmr); // Clear flags since app code wants the new PWM transitions set by this function
}
tmr->pwm = pwm;
while (!(tmr->intfl & MXC_F_TMR_REVB_INTFL_WRDONE_A)) {}
if (timera_is_running) {
tmr->ctrl0 |= MXC_F_TMR_REVB_CTRL0_EN_A; // Unpause A
}
if (timerb_is_running) {
tmr->ctrl0 |= MXC_F_TMR_REVB_CTRL0_EN_B; // Unpause B
}
return E_NO_ERROR;
}There was a problem hiding this comment.
The solution works.
Commit updated.
when timer period end the tmr->count is reset to 0x00000001 and the timer resumes counting. On edge case, when pwm==0 code stuck in while loop Replace while loop with a smart logic that check current status of pwm and reset counter/flags then start a new one Co-authored-by: Jake Carter <jhcarter.co@gmail.com> Signed-off-by: Sadik Ozer <sadik.ozer@analog.com>
87e1bad to
7e0a1d0
Compare
Jake-Carter
approved these changes
Dec 12, 2023
sihyung-maxim
approved these changes
Dec 13, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
For PWM mode when timer period end the tmr->count is reset to 0x00000001 and the timer resumes counting.
On edge case (pwm==0) flow stuck in while loop, tmr->cnt newer become bigger than pwm so that +8 added.
Checklist Before Requesting Review
Test detail
If tolerance value be +8
If tolerance value be +2
As can be seen below due to if checks it is hard to catch exact 0x000001 value, there should be a tolerance value, so that i set it as 8 (TMR clock is PCLK, prescaler=1)
