fix(PeriphDrivers): Fix Unusable MAX32690 I2C Pins #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrentK-ADI
suggested changes
Mar 20, 2024
There was a problem hiding this comment.
It looks like the wrong pins for I2C2C. I believe it is P0.13/P0.14
I was only able to test I2C0 due to the pin outs of the APARD board. I2C1 (P0.11/12) has pull downs and I2C2C (P1.7/8) are used as CTS/RTS for the NINA module. If someone has a generic 140WLP board to test those on, it would be helpful.
sihyung-maxim
approved these changes
Mar 20, 2024
BrentK-ADI
approved these changes
Mar 20, 2024
@sihyung-maxim need to merge #954 |
EricB-ADI
pushed a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 7db1d20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixes #949
The ME18 assigns the same alternate function to both sets of I2C pins. This is logged as an errata (Rev A2 Errata 16), but in order to make the second set of pins usable our drivers will now configure both sets simultaneously.
Doxygen has been updated on the init function to highlight this change:
Checklist Before Requesting Review