tools: scripts: Add dependency on make_dirs #2631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct sequence in the build process is to first create the directory structure for all the source files (in build/app), and then create the symlinks for those files. Since 54c826c ("fix incremental build from Git Bash"), the directory and symlink creation have been moved to different make rules, however there is no dependency between them. This results in compilation errors whenever a multithreaded build is done: [16:08:56] Building for maxim [16:08:56] Building for target max32690 [16:08:56] Creating IDE project ln: failed to create symbolic link 'Downloads/no-OS/projects/apard32690/build/app/noos/drivers/api/no_os_dma.c': No such file or directory make[1]: *** [../../tools/scripts/generic.mk:391: Downloads/no-OS/projects/apard32690/build/app/noos/drivers/api/no_os_dma.c] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [../../tools/scripts/generic.mk:267: all] Error 2 Fix the issue by adding the dependency on make_dirs. Fixes: 54c826c ("fix incremental build from Git Bash") Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
0b885fc to
a244d7c
Compare
buha
approved these changes
Jun 10, 2025
amiclaus
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct sequence in the build process is to first create the directory structure for all the source files (in build/app), and then create the symlinks for those files.
Since 54c826c ("fix incremental build from Git Bash"), the directory and symlink creation have been moved to different make rules, however there is no dependency between them. This results in compilation errors whenever a multithreaded build is done. Fix the issue by adding the dependency on make_dirs.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist